Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Test main.py #54

Merged
merged 3 commits into from
Jun 19, 2024
Merged

Test main.py #54

merged 3 commits into from
Jun 19, 2024

Conversation

rbyrne299
Copy link
Contributor

@rbyrne299 rbyrne299 commented Jun 18, 2024 •
edited
Loading

Black-box testing to check for exceptions given different user input combinations

@rbyrne299 rbyrne299 requested a review from Haadi-Khan June 18, 2024 22:28
Haadi-Khan
Haadi-Khan requested changes Jun 19, 2024
View reviewed changes
Copy link
Member

@Haadi-Khan Haadi-Khan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You're not verifying the actual output of the commands you execute. The initial test I wrote was verifying that the program didn't crash upon start (test_model_ising). You should be verifying the output from the terminal and that it matches expectations.

Haadi-Khan
Haadi-Khan approved these changes Jun 19, 2024
View reviewed changes
Copy link
Member

@Haadi-Khan Haadi-Khan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Future PR will do more in-depth testing for main (i.e. verifying the output from shell cmds)

@Haadi-Khan Haadi-Khan merged commit 6d7e79a into main Jun 19, 2024
1 check passed
@Haadi-Khan Haadi-Khan deleted the test-main branch June 19, 2024 18:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Haadi-Khan Haadi-Khan Haadi-Khan approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rbyrne299 @Haadi-Khan